Skip to content

refactor: fix used void return type #9341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2024
Merged

refactor: fix used void return type #9341

merged 1 commit into from
Dec 28, 2024

Conversation

@paulbalandan
Copy link
Member

Description

  • Used explicit int return types for list command
  • Change test to check for explicit void return

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Dec 27, 2024
@paulbalandan paulbalandan merged commit 19ad2b9 into codeigniter4:develop Dec 28, 2024
41 checks passed
@paulbalandan paulbalandan deleted the method-void branch December 28, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulbalandan @michalsn